Dan Burkert has posted comments on this change. Change subject: spark: add support for fault tolerant scanner ......................................................................
Patch Set 5: (2 comments) Would be nice to have a test of the new functionality (setting the fault tolerant option), even if it doesn't inject faults. http://gerrit.cloudera.org:8080/#/c/6782/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: Line 50: val FAULT_TOLERANT_SCANNER = "kudu.fault.tolerant.scan" hmm should this be something like 'kudu.fault-tolerant-scan'? I typically think of the dots as representing namespaces. Line 147: private val isFaultTolerant: Boolean = faultTolerantScanner; This isn't strictly necessary, you can reference 'FaultTolerantScanner' directly on line 184. The 'val' part of line 135 actually makes it a field automatically. -- To view, visit http://gerrit.cloudera.org:8080/6782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f3192025ca5d74197600480fd3d040d70b4bbc2 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
