Dan Burkert has posted comments on this change. Change subject: spark: add support for fault tolerant scanner ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6782/6/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: Line 78: isFaultTolerant: Boolean, This is a breaking change, so I think we should hold off on doing this. I'm concerned that this API is probably used quite a bit, and this isn't the only option we would want to add (predicates, snapshot timestamp, etc are all missing). I think it's best just to scope this change to SparkSQL (DefaultSource). -- To view, visit http://gerrit.cloudera.org:8080/6782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f3192025ca5d74197600480fd3d040d70b4bbc2 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
