Todd Lipcon has posted comments on this change. Change subject: [rpc] use C++11 move semantics for selected methods ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6766/3/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: Line 159: for (auto it = awaiting_response_.begin(); it != end; ++it) { > Move semantics are making the code significantly more complex here, and onl +1, not worth optimizing this at the expense of clarity -- To view, visit http://gerrit.cloudera.org:8080/6766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7ee8d69a620db597ed9d27c4284656a4169bb09 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
