Dan Burkert has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired ......................................................................
Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/6648/12/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: PS12, Line 415: any other credentials but already existring authn token. I think this would be clearer as 'non-token based authentication' http://gerrit.cloudera.org:8080/#/c/6648/12/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 719: // flight at a time -- there isn't much sense in requesting this information This needs to get a little more fine grained, right? We'd want to start a new ConnectToCluster if we are ignoring the shared token, but the existing one isn't? Definitely hairy. Maybe this is rare enough that we can ignore it, as long as a retry will happen eventually? http://gerrit.cloudera.org:8080/#/c/6648/12/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: Line 162: Status ConnectToCluster(KuduClient* client, Could you document what the token policy does, and examples of when each value might be used? From reading the code it looks like ignore should be used whenever a new token is needed, otherwise USE_SHARED is set? http://gerrit.cloudera.org:8080/#/c/6648/12/src/kudu/rpc/user_credentials.cc File src/kudu/rpc/user_credentials.cc: PS12, Line 47: xxx change this to '<redacted>' to keep it consistent with protobuf redaction. http://gerrit.cloudera.org:8080/#/c/6648/12/src/kudu/rpc/user_credentials.h File src/kudu/rpc/user_credentials.h: Line 30: // around a username string and authn token. I think this may be going the opposite direction of what we'd intended with supporting multiple users / authn credentials in a single krpc system. Todd, what do you think? -- To view, visit http://gerrit.cloudera.org:8080/6648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418497ac59cfd4e476e9bfc6abe6b10b487712f5 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
