Alexey Serbin has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired ......................................................................
Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/6648/12/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 719: // flight at a time -- there isn't much sense in requesting this information > Right. Perhaps then you _do_ want to take into account the token when comp Agreed: there is some things to think just another time. Woops, I didn't realize this simple task would have so many nuances and corner cases. And frankly, I don't feel happy about this code. Probably, that's a sign that another pass is necessary. Thank you for pointing bringing more attention to this. -- To view, visit http://gerrit.cloudera.org:8080/6648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418497ac59cfd4e476e9bfc6abe6b10b487712f5 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
