Todd Lipcon has posted comments on this change. Change subject: KUDU-1056 and KUDU-1020 Safe time for ksck checksum ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6843/1//COMMIT_MSG Commit Message: PS1, Line 9: Now that safe time works properly, this patch enables snapshot : checksum scans in ksck. the commit message doesn't seem quite right, since no changes to the actual ksck code are being made. This is just removing some workarounds from tests, no? http://gerrit.cloudera.org:8080/#/c/6843/1/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: Line 154: // Wait for the first 100 writes so each server should have a chance establish a timestamp. hm, not quite following this. shouldn't servers always have a timestamp? -- To view, visit http://gerrit.cloudera.org:8080/6843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib45be20dcfa37fb85185302adf84d2c4a55f8c1e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
