Andrew Wong has posted comments on this change. Change subject: WIP Allow external miniclusters to use many data dirs ......................................................................
Patch Set 1: (1 comment) Even the most cursory glance is greatly appreciated! http://gerrit.cloudera.org:8080/#/c/6845/1/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 70: // Number of directories to create for each daemon. > Wouldn't it be more natural to convert data_root into e.g. data_roots and a Hmm, the ext cluster currently is organized as: /test-path +-cluster (this level is what is included in data_root) +-daemon (master, ts-0, ts-1) +- data dir (now supports multiple: data-0, data-1 via num_dirs_per_tserver) +- wals, data, etc. I suppose we could specify multiple directories for each cluster, have each directory mirror each other's layout, and spread data that way. e.g. /cluster-0/ts-0/data/{wals,data,etc}, /cluster-1/ts-0/data/data, /cluster-2/ts-0/data/data Where cluster-i is the ith disk on a cluster. Seems a bit complex, but good point that it could be used to test actual multi-disk systems. Is that what you're envisioning? I could see replacing num_dirs_per_tserver with a list of path posfixes, although this would only serve as an aesthetic bump, if anything. -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
