Andrew Wong has posted comments on this change. Change subject: minicluster: facilitate creating multidir clusters ......................................................................
Patch Set 10: (15 comments) http://gerrit.cloudera.org:8080/#/c/6845/1/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 70: // Default: 1 > Yeah, that's more or less what I had in mind. I agree that having multiple data roots could realistic configs (i.e. running a minicluster on a bunch of separate disks). What I'm not sold on is when we would actually want a test to do that. If we wanted to test for perf behavior differences running with some HDDs and some SSDs, for instance, I don't think a minicluster would be the right environment. For now, I've added a bit to this API (even if it is just cosmetic) in hopes it'll be nicer to use. http://gerrit.cloudera.org:8080/#/c/6845/9/src/kudu/integration-tests/multidisk-cluster-itest.cc File src/kudu/integration-tests/multidisk-cluster-itest.cc: Line 34 > warning: using decl 'Substitute' is unused [misc-unused-using-decls] Done Line 35 > warning: using decl 'KuduClient' is unused [misc-unused-using-decls] Done Line 36 > warning: using decl 'KuduSchema' is unused [misc-unused-using-decls] Done Line 39 > warning: using decl 'KuduTableCreator' is unused [misc-unused-using-decls] Done Line 40 > warning: using decl 'KuduSession' is unused [misc-unused-using-decls] Done Line 48 > warning: function 'kudu::MultiDiskClusterITest::InsertPayload' has a defini Done Line 56 > error: use of undeclared identifier 'shared_ptr' [clang-diagnostic-error] Done Line 56 > error: use of undeclared identifier 'session' [clang-diagnostic-error] Done Line 56 > error: 'KuduSession' does not refer to a value [clang-diagnostic-error] Done Line 57 > error: use of undeclared identifier 'session' [clang-diagnostic-error] Done Line 61 > error: no template named 'unique_ptr'; did you mean 'std::unique_ptr'? [cla Done Line 66 > error: use of undeclared identifier 'session' [clang-diagnostic-error] Done Line 67 > error: use of undeclared identifier 'session' [clang-diagnostic-error] Done http://gerrit.cloudera.org:8080/#/c/6845/9/src/kudu/integration-tests/ts_itest-base.h File src/kudu/integration-tests/ts_itest-base.h: Line 101: opts.tserver_path_spec = ts_path_spec; > warning: parameter 'tserver_path_spec' is passed by value and only copied o Done -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
