Todd Lipcon has posted comments on this change. Change subject: faststring: add shrink_to_fit() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6835/1/src/kudu/util/faststring-test.cc File src/kudu/util/faststring-test.cc: PS1, Line 33: TestShrinkToFit_SmallerThanInitialCapacity > nit: TestShrinkToFit_DontShrinkIfSmallerThanInitialCapacity ? or just expla Done http://gerrit.cloudera.org:8080/#/c/6835/1/src/kudu/util/faststring.h File src/kudu/util/faststring.h: PS1, Line 208: // Any pointers within this instance are invalidated. > mention that this doesn't shrink below the initial capacity Done -- To view, visit http://gerrit.cloudera.org:8080/6835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e437ff180fccd1957d252fb9a3551bb91ba7917 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
