Todd Lipcon has posted comments on this change.
Change subject: KUDU-1192 Periodically flush glog buffers from a thread
......................................................................
Patch Set 5:
(3 comments)
Can you also add something like:
google::SetCommandLineOptionWithMode("logbufsecs", "5",
google::FlagSettingMode::SET_FLAGS_DEFAULT);
in ParseCommandLineFlags() in flags.cc? I think changing our default to 5 secs
instead of 30 is a good idea with this change, so that the messages are flushed
a bit quicker.
http://gerrit.cloudera.org:8080/#/c/6853/5/src/kudu/util/async_logger.cc
File src/kudu/util/async_logger.cc:
PS5, Line 120: regardless there
"regardless whether there is"
http://gerrit.cloudera.org:8080/#/c/6853/5/src/kudu/util/logging-test.cc
File src/kudu/util/logging-test.cc:
Line 175: // wait a little more than one wake up cycle
nit: capitalize sentence and end in '.'
nit: "wake-up"
PS5, Line 180: flush
nit: flushed
--
To view, visit http://gerrit.cloudera.org:8080/6853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4c6d440e9259efcf222530f13137f7de5bf00fc
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: William Li <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: William Li <[email protected]>
Gerrit-HasComments: Yes
