Adar Dembo has posted comments on this change. Change subject: Enable move constructors for protobufs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6900/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 519: *pb.mutable_authn_token() = std::move(*authn_token_); > it generated one when I built locally after rm -Rf build/protobuf* from thi Makes sense; the DEBUG console output shows that thirdparty was rebuilt, but the existing protobuf build output appears to have been reused (i.e. protobuf was not recompiled). Is that something we need to address, perhaps by raising the protobuf patchlevel artificially? Or is it safe for this to land as-is? -- To view, visit http://gerrit.cloudera.org:8080/6900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I775e770799aec44cda79e641980e91259d19e650 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
