Todd Lipcon has posted comments on this change. Change subject: Enable move constructors for protobufs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6900/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 519: *pb.mutable_authn_token() = std::move(*authn_token_); > Does SignedTokenPB need a move constructor to handle the move? it generated one when I built locally after rm -Rf build/protobuf* from thirdparty, but I think the thirdparty didn't properly rebuild due to changed CXXFLAGS. -- To view, visit http://gerrit.cloudera.org:8080/6900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I775e770799aec44cda79e641980e91259d19e650 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
