Adar Dembo has posted comments on this change. Change subject: log: reduce segment size from 64MB to 8MB ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6911/1//COMMIT_MSG Commit Message: PS1, Line 7: 64MB to 8MB > experimenting a bit on a server with 6000 tablets right now. I picked 8MB b Is it possible for a single Write RPC to exceed 8 MB? If so, does this change cause any problems for such a Write? PS1, Line 27: This has one risk, in that we currently keep an open file : descriptor for every retained segment We also keep an open fd for every segment being written to, correct? But that number isn't changing; it should still be one fd per tablet, right? -- To view, visit http://gerrit.cloudera.org:8080/6911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcda6b085e69cae5a15d54bb4c945d7605d5f98 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
