Todd Lipcon has posted comments on this change. Change subject: log: reduce segment size from 64MB to 8MB ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6911/1//COMMIT_MSG Commit Message: PS1, Line 7: 64MB to 8MB > it is possible, but I think based on the rolling code it should be fine -- With async preallocation enabled, it seems to do fine, because we check whether the batch is about to overflow the boundary, and if it is, we start an async preallocation but don't actually switch to the new file until the _next_ batch. With async preallocation off, it indeed alternates between large segments (containing a REPLICATE message with the big batch) and small segments (containing just a COMMIT message). But, it seems perfectly happy to restart from this case anyway. Will add a new test which covers this case. Separately, I wonder whether we should remove the 'non-async preallocation' code path entirely, so we have fewer combinations in the code to think about, but I think a bunch of tests rely on it for determinism, so won't try to do that here. -- To view, visit http://gerrit.cloudera.org:8080/6911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcda6b085e69cae5a15d54bb4c945d7605d5f98 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
