Adar Dembo has posted comments on this change. Change subject: process_memory: go back to non-incremental tracking ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6915/1//COMMIT_MSG Commit Message: PS1, Line 34: noticeably better Can you quantify that? http://gerrit.cloudera.org:8080/#/c/6915/1/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: Line 191: const int64_t kReadIntervalMicros = 50000; I'm curious as to how you arrived at this number. My instinct would be to go lower, like 10ms. PS1, Line 198: GetMonoTimeMicros() Shouldn't this be 'time'? -- To view, visit http://gerrit.cloudera.org:8080/6915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8823028de3ea260f1450d9bf34af2dc5a794b206 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
