Adar Dembo has posted comments on this change.

Change subject: process_memory: go back to non-incremental tracking
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6915/1//COMMIT_MSG
Commit Message:

PS1, Line 34: noticeably better
> I think it's more significant -- eg, where the red line crosses 20 us/row, 
Ah yes, the Y axis is raw cpu micros, not percentages. Makes sense, thanks for 
the correction.


http://gerrit.cloudera.org:8080/#/c/6915/1/src/kudu/util/process_memory.cc
File src/kudu/util/process_memory.cc:

Line 191:   const int64_t kReadIntervalMicros = 50000;
> If we're doing 1M inserts/sec, then it must be with a smaller row size (1M 
I buy it.


-- 
To view, visit http://gerrit.cloudera.org:8080/6915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8823028de3ea260f1450d9bf34af2dc5a794b206
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to