Adar Dembo has posted comments on this change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6925/3//COMMIT_MSG Commit Message: PS3, Line 22: to to Double to http://gerrit.cloudera.org:8080/#/c/6925/3/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 336: if (!controller_.status().ok() || !tc_response_.has_error()) { This is, uh, confusing to say the least. Can you pull up the ALREADY_INPROGRESS comment and write something more comprehensive explaining what's going on here and why? http://gerrit.cloudera.org:8080/#/c/6925/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 1067: // Skip calling SetupErrorAndRespond since this path doesn't need the This doesn't actually affect tablet copy operations, right? If SetupErrorAndRespond() is called, it'd convert ServiceUnavailable+THROTTLED into Rpc::ERROR_SERVER_TOO_BUSY but as far as I can tell that has no real effect on Peer::ProcessTabletCopyResponse apart from preventing a noisy LOG(WARNING). Do we actually want that noisy log? -- To view, visit http://gerrit.cloudera.org:8080/6925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffa1f0fec4e882beabfee6e0f2672096caccdf75 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
