Dan Burkert has posted comments on this change. Change subject: KUDU-2020: tserver failure causes multiple tablet copy operations per under-replicated tablet ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6925/3/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 1067: // Skip calling SetupErrorAndRespond since this path doesn't need the > This doesn't actually affect tablet copy operations, right? If SetupErrorAn Yah, this shouldn't have an effect on the actual cluster dynamics. It's useful for testing this specific case, though. I've changed the logging on the leader (consensus_peers.cc) so that all tablet copy failures are logged. I'm going to do another cluster test to verify that this isn't too noisy. Ideally it would be limited to a WARN log every 60 seconds or so, but I'm not sure how to do that on a per-tablet basis. -- To view, visit http://gerrit.cloudera.org:8080/6925 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffa1f0fec4e882beabfee6e0f2672096caccdf75 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
