Todd Lipcon has posted comments on this change. Change subject: threadpool-test: use test fixture ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6944/1/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: Line 42: using strings::Substitute; > warning: using decl 'Substitute' is unused [misc-unused-using-decls] are these Tidy Bot warnings correct? Line 53: ASSERT_OK(ThreadPoolBuilder(kDefaultPoolName).Build(&pool_)); looking at the cases, it seems like almost all of them end up "rebuilding". Maybe it would be cleaner to just not have any default pool and have every test be responsible for building whatever pool they want? -- To view, visit http://gerrit.cloudera.org:8080/6944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic76e5f946356d2cf6869cb7a665d0eeeeba5adde Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
