Todd Lipcon has posted comments on this change. Change subject: Fix flaky test TestRecoverFromOpIdOverflow (again) ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6943/2/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: PS2, Line 75: const int kOneReplica = 1; Don't think this adds much value. If the goal was to make the parameter to StartCluster more obvious, I think it's better to just do: StartCluster(extra_ts_flags, {}, /*replicas=*/ 1); or something of that nature -- To view, visit http://gerrit.cloudera.org:8080/6943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7326136479311ba2a84b384327e07d280df7c3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
