Mike Percy has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 10: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/6772/7/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: Line 453: " config from master: A* B C Yes \n" > Hm you'd have to actually get the RPC to return duplicates from 1 or more t One way to test this is to put replicas on multiple TSes, shut the TSes down, replace one of the TS UUIDs, and restart the cluster. I see your point about the state of the test framework for KsckTest http://gerrit.cloudera.org:8080/#/c/6772/9/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: Line 396: TEST_F(KsckTest, TestConsensusConflictExtraPeer) { > This isn't an integration test. I went to go find the tool-itest I thought Oh, yeah. This test is a bit yuck. http://gerrit.cloudera.org:8080/#/c/6772/10/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: PS10, Line 119: are match extra word: are -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
