Will Berkeley has posted comments on this change. Change subject: KUDU-1860: ksck doesn't identify tablets that are evicted but still in config ......................................................................
Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/6772/8/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: Line 72: const ChecksumOptions& options, > warning: parameter 'options' is unused [misc-unused-parameters] Done http://gerrit.cloudera.org:8080/#/c/6772/8/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 66: using std::setfill; > warning: using decl 'setfill' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/6772/8/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: Line 113: term(term), > warning: value argument 'term' can be moved to avoid copy [misc-move-constr Done http://gerrit.cloudera.org:8080/#/c/6772/8/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: Line 109: using kudu::consensus::ConsensusStatePB; > warning: using decl 'ConsensusStatePB' is unused [misc-unused-using-decls] Done Line 1056: for (const scoped_refptr<TabletReplica> replica : tablet_replicas) { > warning: the loop variable's type is not a reference type; this creates a c Done -- To view, visit http://gerrit.cloudera.org:8080/6772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16e4de09821b372c3773b4ade3fd9e37ab818808 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
