Mike Percy has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs ......................................................................
Patch Set 8: (4 comments) Would you mind running 1000 iters on this test on dist-test just to make sure it's not flaky? http://gerrit.cloudera.org:8080/#/c/6927/8/src/kudu/integration-tests/client_failover-itest.cc File src/kudu/integration-tests/client_failover-itest.cc: PS8, Line 539: start the negotiation process PS8, Line 540: k cl the client's PS8, Line 544: ne the negotiation process PS8, Line 553: FLAGS_rpc_negotiation_timeout_ms Is this reliable? Should it be the rpc timeout * 2 instead just to make sure? Also, it looks like the default rpc negotiation timeout is 3 sec; should we shorten it to make this test complete faster? If we do that, we would need to set it that way in both the client environment and on the cluster. -- To view, visit http://gerrit.cloudera.org:8080/6927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62126c9d8c6c65f447c5d03a0377eaff823393c Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
