Mike Percy has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs ......................................................................
Patch Set 8: (1 comment) I hope we can get rid of the port bind errors by adding a resource lock. Would that be sufficient or do you think something else is going on here i.e. TIME_WAIT? http://gerrit.cloudera.org:8080/#/c/6927/8/src/kudu/integration-tests/client_failover-itest.cc File src/kudu/integration-tests/client_failover-itest.cc: PS8, Line 553: FLAGS_rpc_negotiation_timeout_ms > It's a good point. Ah, yeah it's there in the constructor. Yeah, I guess only doing it on the client is sufficient. Ok let's pull these tests into their own resource locked test file. -- To view, visit http://gerrit.cloudera.org:8080/6927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62126c9d8c6c65f447c5d03a0377eaff823393c Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
