Alexey Serbin has posted comments on this change. Change subject: Add ThreadRestrictions-aware LockGuard and UniqueLock ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7011/4/src/kudu/util/lock_guard.h File src/kudu/util/lock_guard.h: PS4, Line 35: ThreadRestrictions::AssertWaitAllowed(); : } : : ~LockGuard() {} > Does it make sense to restore the original disposition of the 'wait allowed Oh, I misread this. For some reason I read it as SetWaitAllowed(true). -- To view, visit http://gerrit.cloudera.org:8080/7011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87760f2721abab857165ad6e5ac6ac946992a927 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
