Mike Percy has posted comments on this change. Change subject: Add ThreadRestrictions-aware LockGuard and UniqueLock ......................................................................
Patch Set 4: > Also not sure I follow this. Typically these asserts would go in > the lock implementations themselves, rather than the guards, so > that you catch _all_ cases of waiting on the lock, not just the > ones that use our own custom wrapper. Todd are you suggesting we add this to simple_spinlock or create a wrapper of simple_spinlock to do this instead? I think that's more invasive but that would work too. The main purpose of this patch is to "outsource" enforcement of these thread restrictions so we don't have to scatter them across a class when acquiring the lock. -- To view, visit http://gerrit.cloudera.org:8080/7011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87760f2721abab857165ad6e5ac6ac946992a927 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
