Todd Lipcon has posted comments on this change. Change subject: [tests] clean-up on kudu::client::ScanToStrings ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7027/1/src/kudu/client/client-test-util.h File src/kudu/client/client-test-util.h: Line 57: Status ScanToStrings(KuduScanner* scanner, std::vector<std::string>* row_strings); mind adding WARN_UNUSED_RESULT here, just in case anyone is in the midst of rebasing other older patches that might not be checking the result? -- To view, visit http://gerrit.cloudera.org:8080/7027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e7ba56d2e946c1ac9a4db2ef3a542f0a118471d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
