Adar Dembo has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 21: #include <boost/optional.hpp> > I don't think we've standardized on that and I don't really care what we de https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes Seems pretty clear-cut to me: Boost is "Other libraries' .h files", not "C++ system files". I view the fact our thirdparty dependencies are placed on the "system" include path (and thus use triangular brackets instead of double quotes) as an implementation detail. -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
