Andrew Wong has posted comments on this change. Change subject: external minicluster: expand EMC dir usage ......................................................................
Patch Set 19: (7 comments) Retriggered after rebasing to master for tsan build. http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/CMakeLists.txt File src/kudu/integration-tests/CMakeLists.txt: Line 78: ADD_KUDU_TEST(multidir-cluster-itest) > Nit: should come after master-stress-test, and should probably be called mu Done http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 255: CHECK_LE(*dir_index, opts_.num_data_dirs); > Shouldn't this be CHECK_LT? If num_data_dirs=3, the only allowable values f Done Line 269: paths.push_back(GetDataPath(daemon_id, dir_index)); > Nit: use emplace_back() here. Done http://gerrit.cloudera.org:8080/#/c/6845/19/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: Line 21: #include <boost/optional.hpp> > https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includ Yeah thinking about it wrt system-owned vs project-owned makes sense Line 21: #include <boost/optional.hpp> > Nit: this belongs in a separate group after the STL includes, because boost Done Line 300: boost::optional<uint32_t> dir_index = boost::none) const; > Any particular reason we're using uint32_t for this stuff and not 'int'? Mainly because I'd like to keep these indices non-negative. Could accomplish this with some checks, and that would allow us to avoid boost altogether, but using uint32_t makes it more explicit. Line 428: DCHECK_EQ(1, data_dirs_.size()); > Nit: Should probably be CHECK_EQ() given that the other checks you've added Done -- To view, visit http://gerrit.cloudera.org:8080/6845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
