Andrew Wong has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: PS4, Line 79: (deadline < MonoTime::Now() || : (policy == TimeoutHandlingPolicy::FAILOVER_IF_FAULT_TOLERANT && : !co I can't seem to find it in the style guide, is this the convention for multi-line statements? PS4, Line 84: return last_error_.ok() : ? err.status : err.status.CloneAndAppend(last_error_.ToString()); nit: should be able to wrap here, but this may be better for readability, so up to you PS4, Line 272: configuration_.is_fault_tolerant()) { nit: should be able to join lines http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/integration-tests/client-negotiation-failover-itest.cc File src/kudu/integration-tests/client-negotiation-failover-itest.cc: Line 45: using kudu::client::KuduSchema; nit: not yours, but ordering -- To view, visit http://gerrit.cloudera.org:8080/7037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05a3c38cc07c9b6edd1ae773d9850e92645f3b14 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
