Alexey Serbin has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: PS4, Line 79: G(INFO) << "Scan of tablet " << remote_->tablet_id() << " at " : << ts_->ToString() << " deadline expired."; : > I can't seem to find it in the style guide, is this the convention for mult You mean: putting every part of the statement into separate line? I'm not sure that's kind of established convention. Ideally I would like it to be like if (err.result == ScanRpcStatus::TIMED_OUT && (policy == TimeoutHandlingPolicy::FAILOVER_IF_FAULT_TOLERANT && !configuration_.is_fault_tolerant()))) { ... } However, there is a limit on the number of characters in one line. What formatting would you suggest instead? PS4, Line 84: // the black list. : table_->client()->data_->meta_cache_->MarkTSFailed(ts_, err.status); > nit: should be able to wrap here, but this may be better for readability, s I just moved these lines since the shift was not up-to-the coding style. PS4, Line 272: ach individual RPC call. This gives u > nit: should be able to join lines Done http://gerrit.cloudera.org:8080/#/c/7037/4/src/kudu/integration-tests/client-negotiation-failover-itest.cc File src/kudu/integration-tests/client-negotiation-failover-itest.cc: Line 45: using kudu::client::KuduSession; > nit: not yours, but ordering That's all mine :) I added this test. Done. -- To view, visit http://gerrit.cloudera.org:8080/7037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05a3c38cc07c9b6edd1ae773d9850e92645f3b14 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
