Todd Lipcon has posted comments on this change. Change subject: Add script to run clang-tidy against a patch ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4381/3/build-support/compile_flags.py File build-support/compile_flags.py: PS3, Line 29: TODO(todd) it would be nicer to somehow grab these from CMake, but it's : not clear how to do so. > You could pick your favorite test, find its flags.make, and concatenate CXX good idea.. I'm a bit lazy to do it now, though, and I guess you are OK cuz you gave it a +2 -- To view, visit http://gerrit.cloudera.org:8080/4381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6246f4691b0ca143eea4aa8fb6a4b23099ce4e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
