David Ribeiro Alves has posted comments on this change. Change subject: disk failure: handle EIOs on I/O to blocks ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: PS3, Line 628: KUDU_RETURN_OR_HANDLE_EIO I like this version of the macro (without the second call to HandleEIO()) . Maybe drop the KUDU_ prefix (or add an alias) How about: RETURN_NOT_OK_HANDLE_EIO() http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/util/status.h File src/kudu/util/status.h: PS3, Line 104: breif typo -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
