Andrew Wong has posted comments on this change. Change subject: WIP disk failure: coordinate disk failure handling ......................................................................
Patch Set 8: (10 comments) This patch is getting a bit big and there are a few pieces that can be separated. Will break it apart. http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: PS3, Line 184: RETURN_NOT_OK(block_->Read(0, &mal)); > don't quite follow this. if the read fails with an EIO will this continue t This acts like a RETURN_NOT_OK with an extra step to check the posix code. You're right though, they shouldn't be in this layer; removed. http://gerrit.cloudera.org:8080/#/c/7030/4/src/kudu/fs/fs-test-util.h File src/kudu/fs/fs-test-util.h: Line 86: void HandleError(const Status& /* s */, DataDir* /* dir */) const override { > warning: parameter 'dir' is unused [misc-unused-parameters] Done Line 86: void HandleError(const Status& /* s */, DataDir* /* dir */) const override { > warning: parameter 's' is unused [misc-unused-parameters] Done Line 87: } > warning: redundant return statement at the end of a function with a void re Done http://gerrit.cloudera.org:8080/#/c/7030/4/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: Line 851: // a batch which contains some duplicate keys) we need to do so now. > warning: do not use 'else' after 'return' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/7030/4/src/kudu/tserver/ts_disk_failure-test.cc File src/kudu/tserver/ts_disk_failure-test.cc: Line 9: #include "kudu/gutil/strings/substitute.h" > warning: #includes are not sorted properly [llvm-include-order] Done Line 28: using strings::Substitute; > warning: using decl 'set' is unused [misc-unused-using-decls] Done Line 34: class TSDiskFailureTest : public TabletServerTestBase { > warning: using decl 'RpcController' is unused [misc-unused-using-decls] Done Line 36: virtual void SetUp() override { > warning: using decl 'TabletReplica' is unused [misc-unused-using-decls] Done Line 37: TabletServerTestBase::SetUp(); > warning: using decl 'TabletStatePB' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
