Todd Lipcon has submitted this change and it was merged. Change subject: Enable move constructors for protobufs ......................................................................
Enable move constructors for protobufs This enables an experimental option for protobuf to generate move constructors for protos. This should make storing protobufs in containers more performant, and also should allow us to avoid some current patterns where we use ::Swap() instead of relying on more normal looking C++11-style pass-by-value with std::move(). I didn't go through and update places to take advantage of this, except for just trying it in one spot to make sure it compiles properly. I also verified in the generated code that move constructors are being generated. Change-Id: I775e770799aec44cda79e641980e91259d19e650 Reviewed-on: http://gerrit.cloudera.org:8080/6900 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/rpc/client_negotiation.cc M thirdparty/build-definitions.sh M thirdparty/download-thirdparty.sh 3 files changed, 13 insertions(+), 2 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I775e770799aec44cda79e641980e91259d19e650 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
