Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools ......................................................................
Patch Set 8: I ran raft_consensus-itest in slow mode 1000 times both against top-of-tree and after this change. It should be said that since the last run, raft_consensus-itest has gotten noticeable flakier, because I saw 14 failures against top-of-tree and 16 against my changes. Here were the failure classes: - F0611 22:54:31.148939 10821 test_workload.cc:213] Check failed: _s.ok() Bad status: Timed out: unable to retry before timeout: Remote error: Service unavailable: Timed out: could not wait for desired snapshot timestamp to be consistent: Tablet is lagging too much to be able to serve snapshot scan. Lagging by: 47923 ms, (max is 30000 ms):: Remote error: Service unavailable: Timed out: could not wait for desired snapshot timestamp to be consistent: Tablet hasn't heard from leader, or there hasn't been a stable leader for: 2.535s secs, (max is 0.100s): - F0611 22:49:24.987090 7271 test_workload.cc:266] Timed out: Timed out waiting for Table Creation - F0611 22:49:22.728763 1226 test_workload.cc:186] Timed out: Failed to write batch of 1 ops to tablet 336848619f70436b935b784162bddac1 after 3 attempt(s): Failed to write to server: ef05c7170e544b46abe0e50fd497cbf1 (127.0.182.2:44049): Write RPC to 127.0.182.2:44049 timed out after 60.000s (SENT) - F0611 22:51:04.522655 8815 ts_itest-base.h:149] Check failed: _s.ok() Bad status: Timed out: GetTableLocations RPC to 127.0.0.1:52864 timed out after 1.000s (SENT) F0611 22:32:19.580394 181 raft_consensus-itest.cc:308] Check failed: _s.ok() Bad status: Illegal state: Request to resume '/tmp/run_tha_testGIpLRU/build/debug/bin/kudu-tserver' but the process is not there I believe I saw more or less the same failures in both runs so I don't think my changes introduced any new kinds of failures. I have all of the logs if someone wants to see any of these in more detail. -- To view, visit http://gerrit.cloudera.org:8080/6946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8958c607d11ac2e94908670c985059bef0ff5f54 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
