Todd Lipcon has posted comments on this change. Change subject: consensus: consolidate Raft thread pools ......................................................................
Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/6946/12/src/kudu/consensus/consensus_peers-test.cc File src/kudu/consensus/consensus_peers-test.cc: PS12, Line 57: CONCURRENT shouldn't this be SERIAL since it's replacing a pool with max_threads=1? http://gerrit.cloudera.org:8080/#/c/6946/12/src/kudu/server/server_base.h File src/kudu/server/server_base.h: PS12, Line 181: // Thread pool for Raft-related operations, shared between all tablets. : gscoped_ptr<ThreadPool> raft_pool_; not a huge fan of this "kudu-specific" stuff in server/ -- the hope was to keep mostly generic stuff here that would apply to any "server process" built on kudu's reusable stuff. That said, it's largely academic since there are no other such services aside from the tserver and master. (this is the first reference to consensus or raft in the server/ directory, also no references to tablet, etc.) Would it be convenient enough to put this elsewhere? -- To view, visit http://gerrit.cloudera.org:8080/6946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8958c607d11ac2e94908670c985059bef0ff5f54 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
