Hello Andrew Wong, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7151
to review the following change.
Change subject: mini_master: remove CHECK from destructor
......................................................................
mini_master: remove CHECK from destructor
This CHECK isn't safe; it can fire during test setup before the master has
been shut down. For example, consider this (edited) code snippet from
MiniCluster::StartSingleMaster():
gscoped_ptr<MiniMaster> mini_master(new MiniMaster(...));
RETURN_NOT_OK(mini_master->Start());
RETURN_NOT_OK(mini_master->master()->WaitForSomething(...));
mini_masters_.push_back(shared_ptr<MiniMaster>(mini_master.release()));
MiniCluster's destructor guarantees that the masters are shut down before
being destroyed, but if WaitForSomething() fails, the new master won't be
added to mini_masters_ and thus will be destroyed without first being shut
down at the end of StartSingleMaster().
This is the cause of one source of delete_tablet-itest flakiness.
Change-Id: I742e190f751535d2a59354c3b35cdaf0a340d4ea
---
M src/kudu/master/mini_master.cc
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7151/1
--
To view, visit http://gerrit.cloudera.org:8080/7151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I742e190f751535d2a59354c3b35cdaf0a340d4ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
