Andrew Wong has posted comments on this change. Change subject: mini_master: remove CHECK from destructor ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7151/1/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 51 > ~MiniTabletServer() doesn't, so I didn't do that here either. Still might worth considering since Shutdown() may be doing different things for tserver and master. Off the top of my head, I'm not sure if they have the same d'tor behavior, but there may be checks along the d'tor in master_, for instance. Did you run dist-tests to verify the check failures went away (since this is only one source of errors, not sure if that is still the best strategy in verify the removal of flaky code)? -- To view, visit http://gerrit.cloudera.org:8080/7151 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I742e190f751535d2a59354c3b35cdaf0a340d4ea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
