Todd Lipcon has submitted this change and it was merged. Change subject: tidy: enable some identifier naming rules ......................................................................
tidy: enable some identifier naming rules This adds some basic identifier naming rules to our tidy config and fixes some of the aberrations from our style guide. There are many more such options we can add over time, but we're more inconsistent in certain areas (eg FOO_BAR vs kFooBar for constants) and I wanted to start with the rules that we apply most consistently. Change-Id: I9749c4bef61ca780c3543a4894d289ef9a448ea9 Reviewed-on: http://gerrit.cloudera.org:8080/7157 Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Dan Burkert <[email protected]> Reviewed-by: Hao Hao <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/.clang-tidy M src/kudu/benchmarks/tpch/tpch1.cc M src/kudu/client/client-test.cc M src/kudu/common/scan_spec.cc M src/kudu/experiments/rwlock-perf.cc M src/kudu/gutil/hash/hash.cc M src/kudu/gutil/spinlock.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/util/memcmpable_varint.cc M src/kudu/util/memory/memory.cc M src/kudu/util/net/socket.cc M src/kudu/util/striped64.cc 13 files changed, 70 insertions(+), 57 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Hao Hao: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/7157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9749c4bef61ca780c3543a4894d289ef9a448ea9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
