Todd Lipcon has posted comments on this change. Change subject: tidy: add and fix modernize-make-shared ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7161/1/src/kudu/cfile/type_encodings.h File src/kudu/cfile/type_encodings.h: Line 58: template<typename TypeEncodingTraitsClass> TypeEncodingInfo(TypeEncodingTraitsClass t); > warning: single-argument constructors must be marked explicit to avoid unin I'll fix these unrelated tidy warnings separately -- To view, visit http://gerrit.cloudera.org:8080/7161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie859db564e9c91520bb2c74be9cdaa29753694f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
