Alexey Serbin has posted comments on this change. Change subject: [registration-test] fix flake in TestTabletReports ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7209/1/src/kudu/integration-tests/registration-test.cc File src/kudu/integration-tests/registration-test.cc: PS1, Line 201: locations->Swap(&loc); > nit: you can use *locations = std::move(loc) now that we have move-ctors en That's much better. Let me do this and also update the over-complicated commit message :) -- To view, visit http://gerrit.cloudera.org:8080/7209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I906465ad220236538175c80972ae055193f9bb45 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
