Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7209
to look at the new patch set (#3).
Change subject: [registration-test] fix flake in TestTabletReports
......................................................................
[registration-test] fix flake in TestTabletReports
Prior to the fix, the failure rate attributed to this flake was about
0.3% in 1K run:
http://dist-test.cloudera.org//job?job_id=aserbin.1497582474.17739
After the fix, no failures in 1K run:
http://dist-test.cloudera.org//job?job_id=aserbin.1497629325.23427
Both runs were of DEBUG build run with -stress_cpu_threads=8 flag.
The crux of the fix is to use AssertEvetually instead of relying on a
hard-coded delay to capture system catalog's metric. That's because
the metrics of interest are updated upon processing tablet reports from
tservers which contain tablet consensus status information. The latter
are sent with a tserver-->master heartbeat when the tserver determines
that it has become the leader for one of its tablets.
In addition to that, this patch includes a clean-up of the test code.
Change-Id: I906465ad220236538175c80972ae055193f9bb45
---
M src/kudu/integration-tests/registration-test.cc
1 file changed, 58 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/7209/3
--
To view, visit http://gerrit.cloudera.org:8080/7209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I906465ad220236538175c80972ae055193f9bb45
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
