Hello Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7212

to review the following change.

Change subject: Make AssertEventually compatible with --gtest_break_on_failure
......................................................................

Make AssertEventually compatible with --gtest_break_on_failure

ASSERT_EVENTUALLY(...) works by suppressing assertion failures for a
certain number of retries until the specified assertions eventually
succeed. With gtest_break_on_failure, the failed assertions would cause
the test to crash even though they were expected.

Tested with subprocess-test --gtest_break_on_failure

Change-Id: I8e5299c2bb200420cf5ecf6aea8e13d2e44a1e43
---
M src/kudu/util/test_util.cc
1 file changed, 30 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/7212/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e5299c2bb200420cf5ecf6aea8e13d2e44a1e43
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>

Reply via email to