Alexey Serbin has posted comments on this change.

Change subject: [rpc] add method to output TLS cipher description
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7217/1/src/kudu/security/tls_handshake.cc
File src/kudu/security/tls_handshake.cc:

Line 264:   return SSL_CIPHER_description(cipher, buf, sizeof(buf));
> As I saw from the source, if the provided buffer were too small (<128 chara
typo: openSSL 1.2.0 --> OpenSSL 1.0.2


-- 
To view, visit http://gerrit.cloudera.org:8080/7217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6f1c6a67b66fac1dacebe87e17a996af409e6d1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to