Todd Lipcon has posted comments on this change. Change subject: [rpc] add method to output TLS cipher description ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7217/1/src/kudu/security/tls_handshake.cc File src/kudu/security/tls_handshake.cc: Line 261: return "NONE"; do we need to clear pending errors in this case? Line 264: return SSL_CIPHER_description(cipher, buf, sizeof(buf)); if the provided buffer is too small, this returns null, and I think string(nullptr) would crash? it's not clear from the manpage whether it's guaranteed that if the buffer is >128 that it would always be "big enough" also, is this guaranteed not to leave error pending? -- To view, visit http://gerrit.cloudera.org:8080/7217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6f1c6a67b66fac1dacebe87e17a996af409e6d1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
