Alexey Serbin has posted comments on this change.

Change subject: Fix gmock link errors on macOS
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7251/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

PS1, Line 339:   echo Installing gmock...
             :   cp -a $GMOCK_SHARED_BDIR/libgmock.$DYLIB_SUFFIX $PREFIX/lib/
             :   cp -a $GMOCK_STATIC_BDIR/libgmock.a $PREFIX/lib/
             :   rsync -av $GMOCK_SOURCE/include/ $PREFIX/include/
             :   rsync -av $GMOCK_SOURCE/gtest/include/ $PREFIX/include/
So, playing with additional

-DCMAKE_MACOSX_RPATH=xxx

for the 'cmake' command above didn't help?

And CMP0042 didn't work either?


-- 
To view, visit http://gerrit.cloudera.org:8080/7251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41e6d4bfcabb36efbf83fd4969e9f35c16b74f3d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to