Dan Burkert has posted comments on this change. Change subject: Fix gmock link errors on macOS ......................................................................
Patch Set 2: I tried applying the patch here: https://github.com/google/googletest/pull/829, but that had no effect. I believe the two things you mentioned are equivalent. I can't spend any more time on this issue, so I'm going to suggest we merge as is and not investigate more. The rsync install method has worked reliably for the entire life of the project to date. -- To view, visit http://gerrit.cloudera.org:8080/7251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e6d4bfcabb36efbf83fd4969e9f35c16b74f3d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
