Adar Dembo has posted comments on this change. Change subject: tools: refactor table-printing code a bit ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7259/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 863: vector<vector<string>> columns{ sources, voters, terms, indexes, committed }; Not necessary anymore? http://gerrit.cloudera.org:8080/#/c/7259/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: Line 490: DCHECK_EQ(row.size(), columns_.size()); CHECK_EQ, for consistency with AddColumn? -- To view, visit http://gerrit.cloudera.org:8080/7259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e9556a14b6745f6bd07d1aee111bfa5cd9297fe Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
