Todd Lipcon has posted comments on this change. Change subject: tools: refactor table-printing code a bit ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7259/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: Line 863: vector<vector<string>> columns{ sources, voters, terms, indexes, committed }; > Not necessary anymore? Done http://gerrit.cloudera.org:8080/#/c/7259/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: Line 485: : column_names_(std::move(col_names)), > warning: std::move of the variable 'col_names' of the trivially-copyable ty switched it to just use a vector instead of this fancy thing Line 490: DCHECK_EQ(row.size(), columns_.size()); > CHECK_EQ, for consistency with AddColumn? Done Line 493: columns_[i++].emplace_back(std::move(v)); > warning: std::move of the const variable 'v' has no effect; remove std::mov Done http://gerrit.cloudera.org:8080/#/c/7259/1/src/kudu/tools/tool_action_common.h File src/kudu/tools/tool_action_common.h: Line 124: explicit DataTable(std::initializer_list<std::string> col_names); > warning: initializer-list constructor should not be declared explicit [goog changed to vector -- To view, visit http://gerrit.cloudera.org:8080/7259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e9556a14b6745f6bd07d1aee111bfa5cd9297fe Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
